-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pgmanage: fix build #36164
pgmanage: fix build #36164
Conversation
|
@GrahamcOfBorg test pgmanage |
Success on x86_64-linux (full log) Partial log (click to expand)
|
There is a similar problem for pgadmin3. Does it makes sense I spent some time fixing this (for |
@lsix yes, I don't think it will be changed back. |
@@ -11,6 +11,10 @@ stdenv.mkDerivation rec { | |||
sha256 = "0g9kvhs9b6kc1s7j90fqv71amiy9v0w5p906yfvl0j7pf3ayq35a"; | |||
}; | |||
|
|||
patchPhase = '' | |||
sed -e "s~#!/bin/sh~#!$SHELL ~" -i src/configure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
patchShebangs maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not know of patch Shebangs, I’ll look into it. Based on its name, it should do exactly what I expect it to do.
Success on x86_64-linux (full log) Partial log (click to expand)
|
The configure script uses the `command` builtin command which is bash specific while having a "#!/bin/sh" head. This forces the use nix default shell (bash)
@Mic92 I just fixed it. |
Success on aarch64-linux (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
@GrahamcOfBorg test pgmanage |
Success on x86_64-linux (full log) Partial log (click to expand)
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
Motivation for this change
Recent backport of postgresql to 17.09 broke few things, including pgmanage (https://hydra.nixos.org/eval/1437029). While I do not see why this is related, this fixes pgmanage. I’ll check later how this is affecting master.
The configure script uses the
command
builtin command which is bashspecific[1] while having a "#!/bin/sh" head.
This forces the use nix default shell (bash)
[1] https://www.gnu.org/software/bash/manual/html_node/Bash-Builtins.html#Bash-Builtins
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)